✏️ [ FEAT REQ ] Ability to choose what to attach from the compose menu.

[Inhishonor]

Is your feature request related to a problem? If so, please describe the problem. Not really a problem, just a way to clean up the UI.

Describe the feature you'd like When you tap the plus button, multiple options show up, such as add a photo, add a file, or take a photo. I suggest removing add a photo as it is not needed any more.

Additional context I would be willing to submit a pull request if needed.

[octoshrimpy]

a PR would be awesome. :)

[Inhishonor]

Will do. I also realized that the "add a contact" is also unneeded. I'll remove that as well.

[gavine99]

@Inhishonor @octoshrimpy for me, i think better to leave the attach menu items.

usually i prefer less options rather than more, but in this case attach a photo and attach a contact were left on the menu for 2 reasons;

• they take the user to very specific pickers - or direct to selection app if only one app installed that supports the required type
• fast access to the most common attach actions

also, attach a contact requires extra processing to get vcard data from contact data that is currently only done when returning from the 'attach a contact' menu item.

moving to a single 'attach any file' option would require rejiggering how attachment types are determined and handled. this is maybe a good thing to do and might cross-over with issue https://github.com/octoshrimpy/quik/issues/262 if it is chosen to use storage access framework (files app) for all file choosing.

examples from my emulator (but similar enough to my main device);

attach a photo - just 4 image apps to choose from (only apps that specifically support providing image/* mime type);

attach a contact - just 3 contact apps to choose from (only apps that specifically support providing text/x-vcard mime type);

attach any file - 7 apps to choose from - top row are dupes by android for faster selection - (apps that support */* - there could be a lot of apps that support */* on a real device!);

[Inhishonor]

That is a fair point, I personally still prefer the less options, especially when other features are added such as GIFs, encryption, and voice messages. However, if it is decided that it makes more sense to keep them, I will defer.
If we do decide to keep them, can they be reordered? Right now, it seems a little bit random. It may be better for the UX to have it in the following order:

• Take a Photo
• Schedule a message
• Attach a file
• Attach a contact
• Attach a photo

My reasoning for this is that attach a photo would be the most common followed by attach a contact and having it lower on the screen would make it easier to select. Also, users are more likely to select take a photo when the keyboard is down, so having it on top makes it easiest to access. I may be wrong about this...

[gavine99]

i've submitted a pr - https://github.com/octoshrimpy/quik/pull/282 - that is to slightly improve the attachment code but is a precursor to allowing a single 'attach anything' option if people want a single option. maybe a setting could be added that dynamically changes the app from using the 3 attach menu items - photo, contact, and any file - to a single 'attach anything' menu item?? hmmmm. thoughts?

ps. i also submitted pr https://github.com/octoshrimpy/quik/pull/283 to use the files app for picking attachments. for me, i don't like the files app and prefer the pr to never go into the product :) but happy to hear your thoughts on that one as well if you test it out for a time.

[Inhishonor]

I really like that idea of having settings one thing for me I think would be the best option would be to allow the user to choose which items are in the + menu. That way the user could pick if they want to use the SAF, if they want to be able to attach any file, if they want the attached photo, so on and so forth. This could be set up similar to the swipe settings menu. Just a thought.