quik
quik copied to clipboard
octoshrimpy
✏️ [ FEAT REQ ] Darken the orange color to make white text more readable
Is your feature request related to a problem? If so, please describe the problem.
I'd love to use the "Automatic contact colors" option, however I find it difficult to read the text when it selects the lighter orange color as the text background.
Describe the feature you'd like To make the orange color slightly darker, or less saturated.
qksms has some open tickets that may be relevant, I've been running into contrast issues too.
https://github.com/moezbhatti/qksms/issues/1564
https://github.com/moezbhatti/qksms/issues/1920
Agreed. The contact colors look great against a darker bg, but text color needs to be checked against bubble color readability scores for sure.
why not put a toggle on the color selection page to switch between white or black text so that the user can decide how SMS text is displayed if the default contrast is not suitable for them.
Pulse SMS seems to be fairly decent at selecting white or black text depending on overall brightness of the 3 RGB values (i think).
EDIT: I didn't even know QUIK also changed the text to dark... probably because it's so bad at deciding that I didn't even realize it until I started using the color map instead of the Material choices that seem to be tuned poorly for contrast...
A way to color the header of each conversation the same color or an accent color would be nice too. (Pulse does this nicely, and makes differentiating convos easier).
but text color needs to be checked against bubble color readability scores for sure.
@octoshrimpy I was able to find the following values for the speech bubbles with the “Automatic contact colors” setting.
My system is in dark mode. The font size in QUIK is set to “Normal”. I am using version 4.0.7 from F-Droid.
but text color needs to be checked against bubble color readability scores for sure.
@octoshrimpy I was able to find the following values for the speech bubbles with the “Automatic contact colors” setting.
My system is in dark mode. The font size in QUIK is set to “Normal”. I am using version 4.0.7 from F-Droid.
and what are we supposed to do with this information?
and what are we supposed to do with this information?
I think the version concerned is basically good to know for an issue or contributions to it.
As far as I know, the font size has an effect on legibility.
And with the dark mode, I wanted to say that I did the contrast check with the dark theme of QUIK. EDIT: I also tested it with the light theme. The values are identical in this case.
If you are referring to the values found, I would suggest adjusting the color selection for automatic contacts in QUIK.
I would also suggest to adjust the issue title: “Automatic contact colors should be fully accessible.” For example, in line with the W3C Accessibility Guidelines.
@octoshrimpy Is this where the relevant code for such an improvement can be found?
https://github.com/octoshrimpy/quik/blob/1ba78533036634a40ac65ae8c95abebf3950f921/presentation/src/main/res/values/colors.xml#L68-L76
Or are there other parts of the code that should be looked at in this context?