octokit.net
octokit.net copied to clipboard
Cannot get Readme size via octokit.net
Need to access the size of README.md file, only to find that it's not a public property of Readme object.
The property itself is indeed available in native Github API. Better to have it in octokit.net.
I think this should be resolved by:
- Adding
Sizeas a property onOctokit/Models/Response/ReadmeResponse.cs - Adding
Sizeas a property onOctokit/Models/Response/Readme.csand assigning that from theresponse
Marking this as up-for-grabs as it's an ideal small contribution
I worked with Octokit library in the past and wanted to contribute. This is my first open-source contribution. I have added the Size fields to the Readme.cs & ReadmeResponse.cs. Modified the test cases to include the new parameter. I tested it locally. Quick question on adding new fields to a class (and constructor). I added the Size field after the Name field based on the actual API response format. Is that the correct practice to add a new field or any new fields should be added at the last? Thank you so much!
👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!