Pete Gonzalez

Results 687 comments of Pete Gonzalez
trafficstars

I've marked this as `help wanted`. If someone wants to debug it, what you would do is run your `rush install` [in the VS Code debugger](https://rushjs.io/pages/contributing/#debugging-rush) and then look at...

> Maybe this should be clearly documented in the documentation? Yes > Or in this case even a meaningful warning could also be printed when pnpm >= 8 has been...

> 1. If unexported base classes _never/rarely_ represent bad API design, then the `ae-forgotten-export` warning should never be surfaced. The `ae-forgotten-export` warning was introduced because forgotten exports were frequently causing...

> * How do we handle more convoluted inheritances & export patterns? For example, suppose `A` extends `B` extends `C` extends `D`, but only `A` and `C` are exported. I...

> - What are other cases of wanting to document forgotten exports? Enumerating these use cases is probably the best way to straighten this out. Here are some ideas to...

🤔 Here's a possible wrinkle for the `@unexported` tag: **internal-file.ts** ```ts /** @unexported */ export class Pathological { } ``` **index.ts** (entry point) ```ts import { Pathological as Pathological2 }...

> I'm not convinced this is the case. An API consumer won't know that `UserInputBase = Button | Checkbox`, that's an implementation detail that the library does not share with...

> What would it look like if we simply changed the `ae-forgotten-export` warning to enforce that criterion instead? In the projects that I've worked on, I think what would happen...

> I don't quite follow why Option 1 only works in very narrow cases or how using `@partOf` helps. Even in the "convoluted" case I provided, Option 1 can still...

> You're right that if `UserInputBase` is changed to be exported, these URLs will break… but only if the API Documenter "show inherited members" feature described in #3429 is not...