Pete Gonzalez

Results 698 comments of Pete Gonzalez

> Currently, Rush can download and manage the version of the package manager, but not of Node and Rush itself. This means different team members could run into machine-specific issues...

Bazel seems pretty interesting. I need to read more about it. One potential downside is that it seems a bit complicated to install. You need an installer with prebuilt binaries,...

> When you have a moment, can you please take a look? Thanks! Thanks for following up. This is an exciting contribution! I apologize I haven't been able to review...

> +1 The project I am currently working on would also benefit from this feature; when there's bandwidth I think my company just encountered a similar need heheh. I will...

This is admittedly a rare situation (only happens when first setting up a monorepo). But it's not a great "first impression" for newcomers. Let's fix this.

> Note that the dependency is specifically a type-only import - it is not a runtime dependency. This would be the right criteria if the .d.ts file was not part...

I feel like there is a simpler solution. Let me take a crack at it over the weekend.

Draft PR https://github.com/typescript-eslint/typescript-eslint/pull/3623 illustrates how the test could be rewritten so that the mapping table does not become part of the public API. It requires maintaining two lists (`PunctuatorTokenValue` and...

BTW I was curious about how this project gets built: [api-extractor.json]() reads `/dist/index.d.ts` and writes `/dist/ast-spec.ts` which has a `.ts` file extension instead of the normal `.d.ts`. Then [copy-ast-spec.ts](https://github.com/typescript-eslint/typescript-eslint/blob/407a37430d5a8ff59e111993b2585ee162fef821/packages/types/tools/copy-ast-spec.ts) rewrites...

> I think there's less harm in duplicating it. Besides eliminating the `typescript` dependency, the new code is simpler (i.e. easier to read) which probably outweighs the reduced duplication (i.e....