H. C. Kruse

Results 43 comments of H. C. Kruse

I hoped the Carrack would be the only outlier.. Seems like we'd need to manually define the orientation for each ship?

I like the idea, and think it would be best to fix this directly when creating the json files. The sizes are handled here: https://github.com/StarCitizenWiki/scunpacked/blob/4bdb320fefd0be9479dc819afaa0228e0e911de7/Loader/ShipLoader.cs#L530

That'd be the best place to implement it, yes :)

That seems to be an issue with the 3.21 game files, all sizes are `0` in the json files: https://github.com/StarCitizenWiki/scunpacked-data/blob/9642bf2797f799ba0475c28c00a9b96a00340880/ships/anvl_hawk.json#L57

Looking through the source xml files, the bounding box size is set to 0 there aswell ![image](https://github.com/StarCitizenWiki/API/assets/6594492/c4584142-98fd-4c0e-b5ca-fcb8ff8884ba)

Looking over all vehicles this affects exactly four ships: - Aegis Javelin - Anvil Hawk - Anvil Hurricane - Gatac Syulen

Isn't that the current output on the API? ![image](https://github.com/StarCitizenWiki/API/assets/6594492/2e55b2c7-2670-4ea6-823b-444137dffa87)

Ah, got it! Looking at the game data the A2 indeed has a MSD-313 Missile Rack equipped ![image](https://github.com/StarCitizenWiki/API/assets/6594492/bc9762d7-afff-415f-8d99-1781c387aca0) ![image](https://github.com/StarCitizenWiki/API/assets/6594492/e918e02d-aa68-4c15-8fdb-2cea82d42186)

That is somewhat "correct". The `/weapons` endpoint filters items on `type=WeaponPersonal`, which all QuikFlares are placed into. That's why the Multi-Tool and ParaMed can also be found there. I can...

Feel free to re-open for further discussion :)