Marknote icon indicating copy to clipboard operation
Marknote copied to clipboard

Rethink double click to edit

Open octalmage opened this issue 11 years ago • 20 comments

Double clicking to edit is very clean and intuitive but it conflicts with selecting text. I've gotten used to it but I'd still like to be able to double click to select. Sooo, we either need a new way to switch to the editor, or find a way to make it work.

@briedenk suggested finding a way to only switch if whitespace is double clicked, which could work but I'm not positive it's possible.

Whatever we come up with, I'd like to refrain from using a button if possible.

octalmage avatar Sep 10 '14 01:09 octalmage

I'm currently looking at ways to incorporate this into the UX without it just being a button. I agree about the double-click, and I hadn't really even thought of that. A key binding seems too obscure.

mjchamplin avatar Sep 10 '14 18:09 mjchamplin

This may be a little bit of a cop out, but would double clicking on the tab to open the editor work? Or how about double clicking anywhere in the tab bar frame to open the editor on the currently selected note?

ghost avatar Sep 10 '14 21:09 ghost

I feel like if we do that there will also need to be a button. It needs to be either really obvious or really intuitive, and I don't like the idea of it being so "hidden". BUT there may be an intuitive way to indicate that people should click there. I'm thinking it over.

mjchamplin avatar Sep 10 '14 21:09 mjchamplin

We could do hotkeys like, e for edit, d for duplicate, and n for new note.

octalmage avatar Sep 11 '14 03:09 octalmage

I like the idea of hotkeys, but not as the only means of access. You had mentioned tripleclick to move between editor and markdown renderer (sp?). That's not an awful idea.

ghost avatar Sep 11 '14 04:09 ghost

I implemented triple click in 13399e0 and it's not bad! You can select a word with double click and get to the editor easily. Check it out in v0.4.2 (currently uploading Mac build) and let me know what you think!

octalmage avatar Sep 11 '14 09:09 octalmage

Another idea, what if you hold down a key, like command, when you want to select text. So cmd+double click would allow you to select a word.

octalmage avatar Sep 11 '14 11:09 octalmage

I would not be opposed to this.

ghost avatar Sep 11 '14 11:09 ghost

My concern there is you're changing the default functionality. People are used to double-clicking to select, so if they have to re-learn I think it might be frustrating. I think cmd+double click to switch to editor would be more reasonable.

mjchamplin avatar Sep 11 '14 16:09 mjchamplin

Yeah you're right. Well checkout triple click and let me know what you think!

octalmage avatar Sep 11 '14 16:09 octalmage

Not sure how well I like the triple click in practice. Can we do ctrl+double click for selecting text?

ghost avatar Sep 12 '14 06:09 ghost

Still think changing the default method for selecting text is troublesome.

Triple click isn't a natural gesture, I'd never really thought about that before.

I'm leaning toward there being some area of the editor where you double click to switch between. I'm trying to work that out in the UI design and I'll post something once I find a solution I like.

mjchamplin avatar Sep 12 '14 06:09 mjchamplin

I think I like this best. Was it ever determined if double clicking text is distinguishable from double clicking within the window but not on text?

ghost avatar Sep 12 '14 06:09 ghost

@briedenk So I started trying to detect text under the cursor and it worked fine when the note is displaying, but in the editor I ran into issues. Ace uses a TON of little divs to color and position the code and this makes it very difficult. jQuery.nearest got me closer but it's still not there.

Anyway @mjchamplin and I discussed it and we came up with a page curl idea. In the bottom right there will be a small page curl and you'll (double?) click that to get to the editor.

octalmage avatar Sep 15 '14 14:09 octalmage

I like the idea for a page curl a lot. Can't wait to see it implemented.

ghost avatar Sep 16 '14 03:09 ghost

Just added a CSS transition in 5e68d82261414dc7678d619d59d031d46d950736 and it turned out pretty awesome!

octalmage avatar Sep 17 '14 02:09 octalmage

We made the page curl "flat" and it didn't really work with the animation. It just looked like a magic flying triangle!

@mjchamplin, have you had any thoughts about this?

WHY IS THIS SO HARD.

octalmage avatar Sep 26 '14 02:09 octalmage

Actually I have! I had Joey Wilkinson try out Marknote yesterday and he gave me some great feedback, including a way to make that more obvious. I'll mock it up asap.

mjchamplin avatar Sep 26 '14 02:09 mjchamplin

Thank god!

octalmage avatar Sep 26 '14 02:09 octalmage

I miss double click to edit, it was so nice. And look, Capsule does it!

octalmage avatar Oct 14 '14 11:10 octalmage