opam-repository
opam-repository copied to clipboard
tentative package for using netstring with OCaml5
Thanks for this! Have you been in touch with the original author of netstring (@gerdstolpmann)? We do prefer that patches for upstream are not held in opam-repository, but upstream to the original package where possible.
Unfortunately, no. We noticed that a similar PR to the upstream has been open for eight months, while we have several applications that should work with both OCaml5 and Netstring. So, we rushed to create the package...
Understood. Let's wait to see if @gerdstolpmann has any time to advise on his preferred way forward.
even if @gerdstolpmann were to approve this I’m rather on the fence about accepting this PR in this state. I’d rather not for opam-repository to host that big of a patch. Could you create a proper fork instead somewhere and do a release of that?
We will think about it...
Agreed; this is a very large patch to host in the repository directly.
Any update on this?
I also agree that the opam-repository is not the right place to host a 4k diff against an upstream package. Creating a fork and a new release from that fork would be more maintainable in the long term and would put less pressure on opam infrastructure.
Sorry for the delay. We had made a forked version for OCaml5 six months ago, though not tested until now. So we close this.