opam-repository icon indicating copy to clipboard operation
opam-repository copied to clipboard

tentative package for using netstring with OCaml5

Open codinuum opened this issue 2 years ago • 7 comments

codinuum avatar Jun 15 '23 01:06 codinuum

Thanks for this! Have you been in touch with the original author of netstring (@gerdstolpmann)? We do prefer that patches for upstream are not held in opam-repository, but upstream to the original package where possible.

avsm avatar Jun 15 '23 09:06 avsm

Unfortunately, no. We noticed that a similar PR to the upstream has been open for eight months, while we have several applications that should work with both OCaml5 and Netstring. So, we rushed to create the package...

codinuum avatar Jun 15 '23 10:06 codinuum

Understood. Let's wait to see if @gerdstolpmann has any time to advise on his preferred way forward.

avsm avatar Jun 16 '23 10:06 avsm

even if @gerdstolpmann were to approve this I’m rather on the fence about accepting this PR in this state. I’d rather not for opam-repository to host that big of a patch. Could you create a proper fork instead somewhere and do a release of that?

kit-ty-kate avatar Aug 23 '23 14:08 kit-ty-kate

We will think about it...

codinuum avatar Aug 29 '23 02:08 codinuum

Agreed; this is a very large patch to host in the repository directly.

avsm avatar Aug 29 '23 11:08 avsm

Any update on this?

mseri avatar Mar 15 '24 09:03 mseri

I also agree that the opam-repository is not the right place to host a 4k diff against an upstream package. Creating a fork and a new release from that fork would be more maintainable in the long term and would put less pressure on opam infrastructure.

samoht avatar Apr 02 '24 11:04 samoht

Sorry for the delay. We had made a forked version for OCaml5 six months ago, though not tested until now. So we close this.

codinuum avatar Apr 02 '24 12:04 codinuum