ocaml.org icon indicating copy to clipboard operation
ocaml.org copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Feat/events rss feed

Open ishar19 opened this issue 1 year ago • 1 comments

Resolves #2392

ishar19 avatar May 19 '24 11:05 ishar19

Hey @ishar19, this looks awesome! ✨

Here's some things to consider to make this useful for posting updates to social media, and to be useful in RSS readers:

  • the start date of the event should be included in its title
  • instead of using the summary element to hold the location, I would instead use the content element to render the same information that is listed on the event card. Summary element can be omitted.
  • we cannot use the URL to the actual event as atom:id: "The content of an atom:id element MUST be created in a way that assures uniqueness." (see https://www.rfc-editor.org/rfc/rfc4287#section-4.2.6). Using the slug of the event together with its date should be sufficiently unique.

Hey @sabine thanks for the review and insights and recommended changes, let me make those and get back to this Thanks!

ishar19 avatar May 20 '24 14:05 ishar19

so sorry for delay, i was out for a gateway, will try to wrap this up by 2-3 days

ishar19 avatar May 27 '24 07:05 ishar19

hey @sabine i have updated the format, please take a look. Thanks image

ishar19 avatar May 29 '24 09:05 ishar19

We've just merged a PR #2461 which contains generic RSS feed creation logic that could be used here.

cuihtlauac avatar May 29 '24 13:05 cuihtlauac

We've just merged a PR #2461 which contains generic RSS feed creation logic that could be used here.

just saw it, looks really nice, shall i refactor this to use that logic?

ishar19 avatar May 29 '24 22:05 ishar19

Ah yes, that would be awesome!

sabine avatar May 31 '24 14:05 sabine

Ah yes, that would be awesome!

sure thing, will do that ASAP @sabine , thanks for the heads up!

ishar19 avatar Jun 04 '24 03:06 ishar19

Closing this one with link to new PR #2495

ishar19 avatar Jun 08 '24 08:06 ishar19