dune icon indicating copy to clipboard operation
dune copied to clipboard

Package dependencies not being built in some cases

Open gridbugs opened this issue 1 year ago • 4 comments
trafficstars

Here is a simple dune project that depends on the csexp package: https://github.com/gridbugs/dune-pkg-csexp-dep

On my x64 linux (nixos) machine, solving dependencies (dune pkg lock) and then running dune build produces the error:

File "dune", line 3, characters 12-17:
3 |  (libraries csexp))
                ^^^^^
Error: Library "csexp" not found.
-> required by _build/default/foo.exe
-> required by alias all
-> required by alias default

If I manually build the csexp package by running dune build _build/_private/default/.pkg/csexp/target then dune build completes without error.

I was unable to reproduce this on my aarch64 macos machine.

gridbugs avatar Feb 21 '24 02:02 gridbugs

Okay, I understand this issue. Will fix.

rgrinberg avatar Feb 21 '24 05:02 rgrinberg

Is this fixed? I can still reproduce this locally. Also most of the failures in the dashboard fail because of this issue (e.g. https://github.com/gridbugs/dune-pkg-dashboard/actions/runs/8013503480/job/21890644603).

gridbugs avatar Feb 23 '24 04:02 gridbugs

https://github.com/ocaml/dune/pull/10103 Was supposed to fix it. I'll check again.

rgrinberg avatar Feb 23 '24 04:02 rgrinberg

Fixed in #10122

rgrinberg avatar Feb 23 '24 18:02 rgrinberg