obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

libobs: update `simde`

Open tommyvct opened this issue 4 years ago • 3 comments

Description

Update simde to 22b8b97. This enables ARM64 NEON functionality on Windows ARM64 and possibly other ARM64 systems.

Motivation and Context

The current version of simde can't recognize Windows ARM64 as a ARM64 machine, and would use software implementation as a fallback.

I set up a Windows ARM64 CI (https://github.com/simd-everywhere/simde/pull/877) and added ARM64EC handling logic (https://github.com/simd-everywhere/simde/pull/884) to the simde upstream.

Huge thanks to @nemequ!

How Has This Been Tested?

Not yet tested.

  • [ ] Compile the built-in test from simde
  • [x] Compile OBS-Studio on the master branch
  • [ ] Check for crash and performance regression
  • [ ] Compile OBS-Studio on the windows-arm64 branch
  • [ ] Check for crash and performance regression

Types of changes

  • Performance enhancement (non-breaking change which improves efficiency)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [ ] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

tommyvct avatar Aug 04 '21 08:08 tommyvct

I'd personally vote for us to add a clang-format ignore rule for this subdirectory rather than us reformatting an imported dependency.

https://github.com/obsproject/obs-studio/blob/a9352985c797a3a0fe75ae8ba89013f30dc4b5ab/deps/blake2/.clang-format#L1-L3

WizardCM avatar Aug 05 '21 00:08 WizardCM

Please update the PR to update simde v0.7.6 and keep the updated clang-format file.

PatTheMav avatar Jan 10 '24 17:01 PatTheMav

Hello, SIMDe maintainer here; would you like a new PR to update directly to SIMDe 0.8.2 (our latest release)?

mr-c avatar Jul 09 '24 11:07 mr-c

Closing this in favour of making SIMDE an actual 3rd party dependency that is installed either as a system package or provided via obs-deps.

PatTheMav avatar Jul 31 '25 22:07 PatTheMav