obsidian-hub icon indicating copy to clipboard operation
obsidian-hub copied to clipboard

Download numbers for plugins are inflated

Open joethei opened this issue 2 years ago • 5 comments

I just noticed thanks to this: https://discord.com/channels/686053708261228577/694233507500916796/1050499532326187038 that the plugin download numbers in the hub are quite inflated.

This is because the service used to get the badges sums up downloads for all files, from all releases.

The official script only counts downloads for the manifest.json, since Obsidian downloads these files automatically:

  • manifest.json
  • main.js
  • styles.css (if existing)

Depending on if styles.css exits your numbers are inflated by 2 or 3 times.

joethei avatar Dec 08 '22 20:12 joethei

Wow - thank you very much indeed for logging this.

claremacrae avatar Dec 08 '22 21:12 claremacrae

So I think you are specifically talking about plugin download numbers as opposed to theme ones, so I'll edit the title.

claremacrae avatar Dec 08 '22 21:12 claremacrae

Yeah, theme download count's looks correct.

joethei avatar Dec 08 '22 21:12 joethei

The theme download counts are obtained by a script which reads the theme downloads from the obsidian-releases vault.

This issue made me wonder whether we should get the plugin downloads from the same location. The script will typically run once a week, so it won't hammer GitHub.

claremacrae avatar Dec 08 '22 21:12 claremacrae

This could use an other badge style also not perfect but matches the download count of the plugin.

![GitHub Downloads (specific asset, all releases)](https://img.shields.io/github/downloads/4Source/settings-profiles-obsidian-plugin/main.js?style=for-the-badge&logo=github&color=573E7A)

GitHub Downloads (specific asset, all releases)

4Source avatar Mar 02 '24 22:03 4Source