bindplane-agent icon indicating copy to clipboard operation
bindplane-agent copied to clipboard

fix: install_unix.sh breaks with status code 2 in non-interactive environments

Open dithmer opened this issue 1 year ago • 1 comments
trafficstars

Proposed Change

The script "install_unix.sh" was not working in non-interactive shells, because there are tools used (stty and tput) for which a connected tty is mandatory. This is being fixed by a sh-compliant way of checking if the $- contains the i-flag.

Checklist
  • [x] Changes are tested
  • [x] CI has passed

dithmer avatar Aug 24 '24 13:08 dithmer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 24 '24 13:08 CLAassistant

I suggest closing this in favor of #1895

Dylan-M avatar Oct 02 '24 20:10 Dylan-M

I'm going to close this since #1895 has been merged and should solve this problem with an optional flag. Thanks for taking the time to open this PR, it's very much appreciated!

BinaryFissionGames avatar Oct 23 '24 15:10 BinaryFissionGames