icomplete-vertical icon indicating copy to clipboard operation
icomplete-vertical copied to clipboard

Add support for affixation-function

Open minad opened this issue 4 years ago • 5 comments

See also https://github.com/oantolin/embark/issues/169

minad avatar Feb 25 '21 14:02 minad

I won't do this until I can easily install an Emacs that has it. I'd be nervous to add a feature I am unable to test.

oantolin avatar Feb 25 '21 15:02 oantolin

Well, you don't use an Emacs with affixations either, what do you do to test?

oantolin avatar Feb 25 '21 15:02 oantolin

Marginalia generates affixation functions and they are picked up by Selectrum. It works, but I don't have any Emacs built-in affixations :shrug:

minad avatar Feb 25 '21 15:02 minad

Right, so you haven't tested that, for example, the built-in affixations have the type you expected or that they are OK running in whatever buffer you run them, etc. I guess I could go with that wild-west strategy and fix bugs with the built-in affixations when I have access to them.

oantolin avatar Feb 25 '21 15:02 oantolin

Actually I thought the spec is simply enough to do the wild-west approach. @clemera seems to agree :cowboy_hat_face: :horse:

minad avatar Feb 25 '21 15:02 minad