spec icon indicating copy to clipboard operation
spec copied to clipboard

Add childResource to OAM definition spec

Open resouer opened this issue 5 years ago • 3 comments

It has been proved that childResource is a strong need for any abstraction workload (e.g. ContainerizedWorkload), so that Trait controller could know what's the underlying workload object it need to handle with, see: this example. Note that this field is Kubernetes specific for now, but it has been proven to be a generic field required by various implementations.

--- Off Topic ---

That being said, we may also want to add a runtime field to definition object in the future so we can add runtime specific configurations in the definition object? For example:

apiVersion: v1alpha2
kind: TraitDefinition
spec:
  runtimePlatform: Kubernetes
 ...
apiVersion: v1alpha2
kind: TraitDefinition
spec:
  runtimePlatform: ServiceFabric
 ...
apiVersion: v1alpha2
kind: TraitDefinition
spec:
  runtimePlatform: AlibabaCloudFaaS
 ...

resouer avatar Oct 05 '20 19:10 resouer

/cc @ryanzhang-oss @wonderflow

resouer avatar Oct 05 '20 19:10 resouer

I think it's better to create a separate issue on the "runtime", it deserves its own issue :)

ryanzhang-oss avatar Oct 07 '20 20:10 ryanzhang-oss

I agree this proposal, what about make runtimePlatform: Kubernetes as default?

wonderflow avatar Oct 08 '20 03:10 wonderflow