proof-systems icon indicating copy to clipboard operation
proof-systems copied to clipboard

Add a test checking the domain size when building a circuit with gates using same table.

Open dannywillems opened this issue 2 years ago • 1 comments
trafficstars

          Approving, but would have been nice to have a test, even it looks fine regarding the code. Opening a follow-up issue for a 10 min task.

Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1334#pullrequestreview-1734526395

Before this PR, it was duplicating the domain if two gates were using the same table.

dannywillems avatar Nov 16 '23 14:11 dannywillems

More specifically, if distinct lookup patterns used the same table, the table would be added once fr each, which in turn could increase the domain size.

mrmr1993 avatar Nov 16 '23 21:11 mrmr1993

@dannywillems I picked the issue, assuming that it is for external contributor. Can you check the PR?

duguorong009 avatar Jun 21 '24 07:06 duguorong009