proof-systems
proof-systems copied to clipboard
Add a test checking the domain size when building a circuit with gates using same table.
trafficstars
Approving, but would have been nice to have a test, even it looks fine regarding the code. Opening a follow-up issue for a 10 min task.
Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1334#pullrequestreview-1734526395
Before this PR, it was duplicating the domain if two gates were using the same table.
More specifically, if distinct lookup patterns used the same table, the table would be added once fr each, which in turn could increase the domain size.
@dannywillems I picked the issue, assuming that it is for external contributor. Can you check the PR?