Xuan-Phi Nguyen

We got repetition degeneration when one item in the batch has finish generating. ``` # batch=2 [INST] What is shown in this image? [/INST] 2 cats lying on a pink...

@NielsRogge Ok, I also got your response when using this PR alone. And I found that this PR and my internal code (which I port the PR from) is same...

I got the same results either with or without `model.config.use_cache=False `

@NielsRogge @ArthurZucker I figure it out and has push the updated code. Please give a test! Basically what went wrong: - batched generation always require `padding_side = "left"` - the...

@NielsRogge There you go, kindly review the updated code.

The current implementation of the processor no longer support multi-image in same sequence. I would suggest we support that by add another `num_images` dimension to pixel_values `(batch_size, num_images, num_patches, 3,...

@NielsRogge is this pad function what you expected? https://github.com/huggingface/transformers/blob/685892cb6c13e0d17043d58f8997011b6fd75823/src/transformers/models/llava_next/image_processing_llava_next.py#L449

> It's in the right direction, but any image processing method should always take a numpy array as input and produce a numpy array. In case of padding, one can...

@NielsRogge @zucchini-nlp Resolved the issues. Should be ready to merge.

> Thanks, made some final comments, after that I'll assign Amy for approval. Added the "remove comments" update