website-v2 icon indicating copy to clipboard operation
website-v2 copied to clipboard

docs(pt): update and improve the readability of the content

Open nazarepiedady opened this issue 2 years ago • 17 comments

In this pull request, I am sending impactful updates to the readability of the Portuguese content to ease even more
the learning process of the framework without too much mental effort to understand the content.

@smarroufin and @ChristopheCVB

nazarepiedady avatar Dec 22 '22 21:12 nazarepiedady

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

codesandbox[bot] avatar Dec 22 '22 21:12 codesandbox[bot]

Deploy request for nuxt pending review.

Visit the deploys page to approve it

Name Link
Latest commit b3e8f938cc104615a11f25ebdff4bbaa31cea002

netlify[bot] avatar Dec 22 '22 21:12 netlify[bot]

Live Preview ready!

Name Edit Preview Latest Commit
nuxtjs.org Edit on Studio ↗︎ View Live Preview bd2847e25f146c02e4479399477c6fdc9412ed8a

nuxt-studio-dev[bot] avatar Dec 22 '22 21:12 nuxt-studio-dev[bot]

Deploy Preview for nuxtjs.org ready!

Name Link
Latest commit be858e516d436649b401ca5e293e8599e71e059a
Deploy Preview https://nuxtjs.org?preview=ce4d08025176dbc41dbb5e6c8cc2e3eb

nuxt-studio-dev[bot] avatar Dec 22 '22 21:12 nuxt-studio-dev[bot]

@smarroufin the points marked were resolved.

nazarepiedady avatar Dec 30 '22 02:12 nazarepiedady

@nazarepiedady You still need to rollback the vue router links, keep the v3. in the url.

smarroufin avatar Jan 03 '23 09:01 smarroufin

@smarroufin recently some updates were added to the repository that changed the URLs to Nuxt 3 to this form that I used https://nuxt.com, so is it still necessary to do the change back?

nazarepiedady avatar Jan 07 '23 13:01 nazarepiedady

This repository has nothing to do with Nuxt v3, and so with Vue Router v4. All the docs here is Nuxt v2 and Vue Router v3, and it shouldn't change.

smarroufin avatar Jan 09 '23 09:01 smarroufin

This repository has nothing to do with Nuxt v3, and so with Vue Router v4. All the docs here is Nuxt v2 and Vue Router v3, and it shouldn't change.

@smarroufin I understand, so I will do the possible to adjust all to be well done.

nazarepiedady avatar Jan 11 '23 09:01 nazarepiedady

@smarroufin and @ChristopheCVB I am going to update and improve the content, so any problem was found as before I am open to fixing it.

nazarepiedady avatar Jan 23 '23 10:01 nazarepiedady

All good for me, except the updates on VueRouter urls that need to be reverted: CleanShot 2023-01-24 at 10 57 54

And waiting for @ChristopheCVB for protuguese approval.

smarroufin avatar Jan 24 '23 09:01 smarroufin

@ChristopheCVB the problems found until now are solved. I am waiting for your feedback and possibly new issues to solve.

nazarepiedady avatar Jan 24 '23 14:01 nazarepiedady

@smarroufin and @ChristopheCVB there are many pull requests being merged before this one, those that touch on the files I am working on and when I have to update the local repository to send you an updated changes those updates insert too many conflicts to enhancements.

@smarroufin things are becoming too hard for me to have to wait so long to have the pull requests merged to the main branch. :sweat_smile:

nazarepiedady avatar Feb 02 '23 04:02 nazarepiedady

@nazarepiedady Totally agree, but due to the size of the PR and our synchronization, we are doing our best. @ChristopheCVB is contributing on his free time and sometimes can't review before a while.

Anyways, the PR can't be merged with the Vue Router links you changed. You still need to put back the v3. prefix on them (there are 13 replacements to make). For the portuguese translation, still waiting for an approval.

smarroufin avatar Feb 02 '23 10:02 smarroufin

@smarroufin I thought I already did this, do the issue still remain? :sweat_smile:

nazarepiedady avatar Feb 02 '23 15:02 nazarepiedady

You did fix two wrong urls, but there still are 13 to fix.

smarroufin avatar Feb 02 '23 16:02 smarroufin

Okay, I will fix them too.

nazarepiedady avatar Feb 02 '23 17:02 nazarepiedady

@smarroufin and @ChristopheCVB, I am closing this pull request in order to start a sequence of small and concise pull request that can facilitate the review.

nazarepiedady avatar Feb 27 '24 09:02 nazarepiedady