website-v2 icon indicating copy to clipboard operation
website-v2 copied to clipboard

fix: revert back `/2.x`

Open farnabaz opened this issue 4 years ago • 12 comments

Update @docus/core version to allow Semvers in content files name.

This update will ignore pattern /^(\d+)(\.\d+)*(\.x)?$/. File which match this pattern will same same slug as file name.

1/index.md        --> /1
1.1/index.md      -> /1.1
1.x/index.md      --> /1.x
1.2.x/index.md    --> /1.2.x

farnabaz avatar Oct 19 '21 13:10 farnabaz

Awesome! Do you mind to update content/ directory and remove redirect rules in static/_redirects?

pi0 avatar Oct 19 '21 13:10 pi0

There is small issue in AsideNavigation component. Navigation shows a back button in Docs home page.

Screen Shot 2021-10-19 at 5 42 25 PM

farnabaz avatar Oct 19 '21 14:10 farnabaz

@farnabaz Sorry I didn't react. Do you want me to update the Aside (remove/update this back link), in order to proceed further?

smarroufin avatar Oct 21 '21 14:10 smarroufin

@smarroufin It would be great if you can take a look at it and fix the behavior 🙏

farnabaz avatar Oct 21 '21 15:10 farnabaz

I haven't seen any Docus website with this back button working. In which case does it show? :shrug: If it was just me, I'd simply remove it.

smarroufin avatar Oct 21 '21 15:10 smarroufin

@Tahul might remember the logic/reason of this back button?

farnabaz avatar Oct 21 '21 15:10 farnabaz

@smarroufin @farnabaz Would you please help to resolve conflicts and merging this? 🙏

pi0 avatar Oct 27 '21 11:10 pi0

✔️ Deploy Preview for nuxt ready!

🔨 Explore the source changes: 1e38b732aec56f9d63389f740bbb2f5f07e20419

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt/deploys/617993c6cac6250008b1262d

😎 Browse the preview: https://deploy-preview-1870--nuxt.netlify.app

netlify[bot] avatar Oct 27 '21 13:10 netlify[bot]

@pi0 @farnabaz Discussed with Tahul, should not be needed anymore, plus we don't want it displayed. So I disabled it.

smarroufin avatar Oct 27 '21 13:10 smarroufin

I don't know if it's related by I don't see the Version 2.15 in the left sidebar in the preview (https://deploy-preview-1870--nuxt.netlify.app)

Screenshot 2021-10-29 at 12 11 44@2x

atinux avatar Oct 29 '21 10:10 atinux

Weird one. Might be due to the docus/core resolution :shrug: The issue is that github releases are not found, so there is no last release.

    useFetch(async () => {
      const { body } = await $docus.data('github-releases')

      if (body?.releases?.length) {
        lastRelease.value = body.releases[0].name
      }
    })

smarroufin avatar Oct 29 '21 10:10 smarroufin

Oh that might be due of the environment variables not available for the preview url!

atinux avatar Oct 29 '21 10:10 atinux