image
image copied to clipboard
fix: nuxtpicture placeholder
Closes #1160.
Adds placeholder behavior to NuxtPicture by initially setting the img element's src tag to the placeholder, waiting for the main src to load, and then showing the image.
Codecov Report
Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
Project coverage is 62.44%. Comparing base (
4efdc0b) to head (b0a6bb3). Report is 307 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/runtime/components/_base.ts | 89.28% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 62.20% 62.44% +0.23%
==========================================
Files 79 79
Lines 3593 3605 +12
Branches 391 401 +10
==========================================
+ Hits 2235 2251 +16
+ Misses 1328 1324 -4
Partials 30 30
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Great work guys. Looking forward to this fix. What's the holdup?
https://github.com/nuxt/image/pull/1396#discussion_r1732789360