framework icon indicating copy to clipboard operation
framework copied to clipboard

feat(pages): routes HMR

Open antfu opened this issue 2 years ago • 4 comments

🔗 Linked issue

❓ Type of change

  • [ ] 📖 Documentation (updates to the documentation or readme)
  • [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [ ] 👌 Enhancement (improving an existing functionality like performance)
  • [x] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This make adding/removing routes HMR, without requiring a full reload.

📝 Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

antfu avatar Nov 13 '22 01:11 antfu

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

codesandbox[bot] avatar Nov 13 '22 01:11 codesandbox[bot]

Deploy Preview for nuxt3-docs ready!

Name Link
Latest commit 78b7c7bc31eb7f1d2a0c2e396c6255be93290d0d
Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6370455604777a00091bdda6
Deploy Preview https://deploy-preview-8941--nuxt3-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 13 '22 01:11 netlify[bot]

/cc @posva 👀

antfu avatar Nov 13 '22 01:11 antfu

Thank you! This will be amazing 🚀

danielroe avatar Nov 14 '22 09:11 danielroe

@antfu I was checking this out but I think something must have changed elsewhere (maybe in vite or vite-node?) as the onUpdate function isn't getting called when a new page is added or changed. Do you have any idea what the issue might be?

edit: marking as draft until you get a chance to look at it, for easier triage

danielroe avatar Jan 21 '23 14:01 danielroe