create-nuxt-app icon indicating copy to clipboard operation
create-nuxt-app copied to clipboard

Published 20 hours ago • verified publisher icon nuxt

feat(cna,template): add src directory prompt

Open nozomuikuta opened this issue 4 years ago • 1 comments

Resolve #243 (maybe)

I don't know who mainly manages this repository. So let me request a review from @Atinux and please change reviewers as needed. 🙏

@ushironoko

Is this what you meant in the original issue? If so, I appreciate your review on this PR too. If not, I appreciate additional explanation in the original issue so that I could help.

Explanation of work

Most are explained in the code.

Just in case, I checked files in cna-template/template/frameworks directory, and I believe there is no relative paths (e.g. ../) used to refer to other files. This means changing srcDir doesn't break any such statements. If I should add unit tests for combination of srcDir and frameworks, I will so let me know.

👷‍♂️ Since this is my very first PR for create-nuxt-app tool, I may be making mistakes or missing something. 👷‍♀️

nozomuikuta avatar Sep 21 '21 05:09 nozomuikuta

Actually I still need to discuss with the team but I am not found of adding such question at the beginning, this is quite an advanced usage and should not be directly in the scaffolding tool.

atinux avatar Sep 29 '21 16:09 atinux

Let me close this PR since it's stale.

nozomuikuta avatar Sep 26 '23 10:09 nozomuikuta