content icon indicating copy to clipboard operation
content copied to clipboard

feat: create chunk for components

Open farnabaz opened this issue 3 years ago • 4 comments

🔗 Linked issue

❓ Type of change

  • [ ] 📖 Documentation (updates to the documentation or readme)
  • [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [x] 👌 Enhancement (improving an existing functionality like performance)
  • [ ] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

farnabaz avatar Sep 05 '22 12:09 farnabaz

Deploy Preview for nuxt-content ready!

Name Link
Latest commit 96b7b17d4557411c1d114039306f7d6d2f88ee38
Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/631604257ed34d000a7dcef4
Deploy Preview https://deploy-preview-1501--nuxt-content.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 05 '22 12:09 netlify[bot]

I believe that could be nice to do the same for global components as well in components/content/ (supporting extends too)

atinux avatar Sep 05 '22 14:09 atinux

I believe that could be nice to do the same for global components as well in components/content/ (supporting extends too)

Indeed, I think it will be good to generate a separate chunk for them.

Note!!! Currently, the vue-router and some other packages are bundling into our custom chunk instead of entry. The chunk size is around 120kb with Vue router and others.

farnabaz avatar Sep 05 '22 14:09 farnabaz

Good luck finding this 😅

atinux avatar Sep 05 '22 15:09 atinux

Is there a ticket or description on what this change improves? I'm interested! :nerd_face:

dargmuesli avatar Oct 07 '22 12:10 dargmuesli