color-mode icon indicating copy to clipboard operation
color-mode copied to clipboard

fix: added support for IE 11

Open shtinmn opened this issue 4 years ago β€’ 8 comments

  • Added support for IE 11 ( don't forget to build script.min.js =) )

I'm not 100% sure that babel can be divided into test and production, pay attention to this.

Thank's

shtinmn avatar Mar 04 '21 13:03 shtinmn

Codecov Report

Merging #73 (9adef79) into master (2ec55d6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           19        19           
  Branches         2         2           
=========================================
  Hits            19        19           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 2ec55d6...9adef79. Read the comment docs.

codecov[bot] avatar Mar 04 '21 14:03 codecov[bot]

Hi @shtinmn

Thanks for the PR! Do you mind fixing the conflicts please?

atinux avatar Mar 10 '21 19:03 atinux

Hi, @Atinux

I'm fixed conflict with help rebase, but I'm don't know, rightly that I created additional commit "merge branch 'dev' of ..."

shtinmn avatar Mar 11 '21 06:03 shtinmn

I would love a second thought from @pi0

atinux avatar Mar 14 '21 14:03 atinux

I believe this PR should wait for the removal of babel-preset-env in Nuxt 2.16

atinux avatar May 20 '21 13:05 atinux

Hi @shtinmn

What is the issue with IE11 actually?

atinux avatar Jun 14 '21 09:06 atinux

Hi, @Atinux Check this https://github.com/nuxt-community/color-mode-module/issues/11#issuecomment-789506373

There I described my problem in detail

shtinmn avatar Jun 14 '21 09:06 shtinmn

Can you please update your PR (or create another one) to not update the package.json and unrelated files to this PR please?

atinux avatar Jun 16 '21 11:06 atinux