legacy-modules icon indicating copy to clipboard operation
legacy-modules copied to clipboard

Is it a good idea to use latest version in all packages?

Open shirohana opened this issue 8 years ago • 5 comments
trafficstars

I see bulma was already in 0.6.1 but in @nuxtjs/bulma was just ^0.5.1.

Since you use a helper module, that means you didn't care about which version you used but it should be the newest one.

I mean, if you want to use the older version, just look around how @nuxtjs/bulma was made and specify the version when adding it, and no needs to send a issue or pr for upgrading dependencies in @nuxtjs/modules anymore.

"dependencies": {
  "bulma": "latest"
}

https://github.com/nuxt-community/modules/blob/master/packages/bulma/package.json#L12

This question is available on Nuxt.js community (#c98)

shirohana avatar Nov 08 '17 07:11 shirohana

I think the modules should not depend these frameworks directly, maybe peerDependencies is a choice.

We can let users add specific version dependency by themselves.

@Atinux @pi0 What do you think about ?

clarkdo avatar Nov 13 '17 08:11 clarkdo

Bulma is v0.7.0 now, but in nuxtjs is v0.6.1 only. ~~Is there any workaround how to use latest bulma?~~ I found that I can to not use this module in my project, everything works well with bulma as project dependency!

core01 avatar Apr 24 '18 01:04 core01

@clarkdo I agree with you, in that case, we would have to implement peerDependencies on all modules, right?

anteriovieira avatar May 29 '18 20:05 anteriovieira

@anteriovieira Yeah, we may change it one by one and keep discussing. 😸

clarkdo avatar May 29 '18 21:05 clarkdo

Okay, so I'm going to start with a pull request for @nuxtjs/bulma :smiley:

anteriovieira avatar May 29 '18 22:05 anteriovieira