lighthouse Pass the path array to the `key` method of `CacheKeyAndTags` class

Pass the path array to the `key` method of `CacheKeyAndTags` class

Open mostafa-rz opened this issue 3 years ago • 5 comments

Changes

Pass the resolveInfo->path array to the key method of CacheKeyAndTags class.

Breaking changes

interface signautre change.

Jun 27 '22 15:06 mostafa-rz

This is a breaking change because we are changing the signature of the interface.

Jun 27 '22 17:06 spawnia

@spawnia Would you mind if also changing the signature of the parentTag and fieldTag method? Add resolveInfo and remove parentName and fieldName.

Jun 28 '22 08:06 mostafa-rz

Yeah, that keeps it consistent.

Jun 28 '22 08:06 spawnia

@spawnia Is there any timetable for version 6 release?

Jun 29 '22 08:06 mostafa-rz

@spawnia Is there any timetable for version 6 release?

No, but I reckon it will be a few months. If you need this soon, you can fork or overwrite the involved directives.

Jun 29 '22 09:06 spawnia

Please update this merge request with the latest changes from master. I just made the cut to work towards the upcoming v6.

Jan 23 '23 14:01 spawnia

Missing Changelog. Also, why do you want to make this change at all, what is the use case?

Jan 26 '23 09:01 spawnia

I apply local scopes to fields based on the path. The parent and field name is not enough to differentiate between the cache keys.

Jan 26 '23 10:01 mostafa-rz