nu-ansi-term icon indicating copy to clipboard operation
nu-ansi-term copied to clipboard

examples: run clippy and fix issues

Open jaudiger opened this issue 1 year ago • 3 comments

Hello there, it's quite a while the last time I opened a PR here. This time I just ran clippy in the examples folder, and resolved the issues that were reported.

Please let me know if you don't want this PR as is.

jaudiger avatar May 17 '24 15:05 jaudiger

Let's think about it because this crate is a pain to update for nushell because we publish a new version, then we have to wait for lscolors to publish a new version, then we have to wait for reedline, and then finally we can use it in nushell. So, if it's not significant changes, I'm inclined to just wait on this until the next significant change.

fdncred avatar May 17 '24 15:05 fdncred

Sure, I understand. I did open one last PR (https://github.com/nushell/nu-ansi-term/pull/59) but on the source folder this time. It has the advantages to derive few must_use macro. But I'm opened to updating both PR if needed, of course.

jaudiger avatar May 17 '24 15:05 jaudiger

When I run cargo clippy in the examples/ folder, nothing shows up.

kubouch avatar Jun 29 '24 08:06 kubouch