zigbee2mqtt-frontend icon indicating copy to clipboard operation
zigbee2mqtt-frontend copied to clipboard

[Bug]: Confirmation dialogs are not specific enough and are not easily accessible

Open nomike opened this issue 8 months ago • 0 comments

What happened?

When I click the interview or the reconfigure button on a device, a confirmation dialog is shown titled "Confirmation Prompt" with the text "Are you sure?" and the options "Close" and "OK".

Especially when I'm in a list of devices, there are situations where I'm not sure whether I clicked on the button for the correct device and it's also not clear whether I maybe accidentally clicked on "reconfigure" instead of "interview".

Image

What did you expect to happen?

IMHO the confirmation dialog should contain more information, so that I'm aware of what I'm confirming.

The dialog box should contain a prompt indicating what I'm giving consent to.

Ideally the buttons should indicate more directly what will happen when I click them (e.g. "Abort", "Interview" instead of "Close", "OK". [Remark on the "Close" or "Abort" label: The pending action is to interview a device. At the beginning of that process, I am asked whether I want that action to continue. So aborting the action feels more natural then "close", because that just refers to c;losing the dialog box, which I don't really care about. It's just a tool]).

Accessibility

Additionally there is an accessibility issue: I can only operate the dialog with the mouse. The standard behavior for alert dialogs like this is to confirm by pressing enter and to cancel the dialog with the escape key (see for example the dialogs section of the human interface guidelines of the gnome project).

I've created a mock-up of how this dialog could look like:

Image

How to reproduce it (minimal and precise)

Open the devices list in Zigbee2MQTT and click on any of the "Interview" or "Reconfigure" buttons.

Zigbee2MQTT version

2.1.3-1

state.json.zip

What browsers are you seeing the problem on?

Probably all

Did you download state.json.zip?

I will attach state.json.zip

nomike avatar Mar 11 '25 00:03 nomike