zigbee2mqtt-frontend icon indicating copy to clipboard operation
zigbee2mqtt-frontend copied to clipboard

[Bug] Log level prevents actions feedback in frontend

Open Nerivec opened this issue 1 year ago • 1 comments

What happened?

If log level is set above info, then it hides notifies like no update available, resulting in buttons that seemingly do not work (even though they do).

I can confirm the behavior for at least the Check for new updates & Check all buttons on the OTA page. I do believe it would be the same for any button/link that expects feedback from logger.

It seems this kind of notify would have to be decoupled from automatic logging>notify, but I don't know this codebase enough (yet) to efficiently make a PR. However, a PR was recently merged in zhc to improve OTA overall errors/logging and soft fail on images not available (as opposed to no update available); it should hopefully make this easier.

What browsers are you seeing the problem on?

Chrome

Relevant stacktrace

No response

Did you download state.json.zip?

I will not attach state.json.zip

Nerivec avatar Jan 07 '24 01:01 Nerivec

Instead of relying on the transport (which only logs for the set log level) we should hook directly into logger.ts and publish logs to the frontend here

Koenkk avatar Jan 07 '24 08:01 Koenkk