zigbee2mqtt-frontend icon indicating copy to clipboard operation
zigbee2mqtt-frontend copied to clipboard

[Bug]: Item remove button on settings page for setting/options like debounce_ignore does nothing

Open Impact123 opened this issue 3 years ago • 3 comments

What happened?

Problem

The red - button in the device's Settings page for options like ignore_debounce, filtered_optimistic, filtered_attributes does not remove the item.

Clicking the - here will do nothing. At least not after it was saved. image

Writing the options via MQTT like

{
    "id": "mydeviceid",
    "options": {
        "debounce_ignore": null,
        "filtered_optimistic": null,
        "filtered_attributes": null
    }
}

to zigbee2mqtt/bridge/request/device/options works fine.

How to reproduce

  1. Go to a device's Settings tab.
  2. Add a Ignore debounce option.
  3. Save/Submit
  4. Click the - to attempt remove the option

Expected behavior

I expected the option to be removed

Proposed solution

Remove the option. Set it to null when it's the last to remove it completely

Further information

Tested with

Software Version
Zigbee2MQTT 1.25.0-dev (8c4312d)
Frontend 0.6.83
Chrome 100.0.4896.88

Addendum

It's not a bug but it would be nice if other options could be reset/removed too. You can't remove the icon, for example.

What browsers are you seeing the problem on?

Chrome

Relevant stacktrace

No response

Did you download state.json.zip?

I will not attach state.json.zip

Impact123 avatar Apr 18 '22 20:04 Impact123

I can confirm this. Had to manualy edit my config file.

sammyke007 avatar May 20 '22 11:05 sammyke007

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 16:07 stale[bot]

Bump to keep the bot happy. This is still an issue.

Impact123 avatar Jul 30 '22 16:07 Impact123

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 30 '22 19:09 stale[bot]

Unstale.

Impact123 avatar Sep 30 '22 21:09 Impact123

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '22 23:12 stale[bot]

I must've missed to unstale this. Please reopen. This is still an issue.

Impact123 avatar Dec 16 '22 05:12 Impact123