phpinsights icon indicating copy to clipboard operation
phpinsights copied to clipboard

Published 20 hours ago • verified publisher icon nunomaduro

Add option to set timeout

Open holymp2006 opened this issue 3 years ago • 3 comments

Q A
Bug fix? yes
New feature? no
Fixed tickets #546

Add config option to set timeout.

holymp2006 avatar Aug 26 '22 20:08 holymp2006

Hi @holymp2006, this looks like a great addition! Can you please remove your aabac89 commit and rebase from the current master branch? That change is no longer needed.

cmgmyr avatar Sep 03 '22 11:09 cmgmyr

Hello @cmgmyr , reverted the aabac89 commit and rebased from the current master branch.

holymp2006 avatar Sep 03 '22 16:09 holymp2006

Thanks @holymp2006, it looks like we have some various failures from the test suite. Rebasing or pulling in master might fix them, or there might be other issues in the changed code. Please LMK if you need help going through any of the items.

cmgmyr avatar Sep 03 '22 20:09 cmgmyr

what is needed for this pull to be merged?

gemal avatar Dec 01 '22 10:12 gemal

can this be merged?

gemal avatar Mar 22 '23 07:03 gemal

I rebased off current master, and most of the failures seem to be around styling. I'll take a closer look shortly and we should be able to merge

cmgmyr avatar Mar 22 '23 10:03 cmgmyr

image

gemal avatar Mar 22 '23 11:03 gemal

Nice! All checks have passed...

gemal avatar Mar 23 '23 11:03 gemal

I'm experiencing timeouts for a while now and this is a great feature to help resolve that. When will this be released?

joelvh avatar Oct 17 '23 22:10 joelvh

Just released in v2.9.0 👍

cmgmyr avatar Oct 20 '23 16:10 cmgmyr

Thank you @cmgmyr!

joelvh avatar Oct 20 '23 16:10 joelvh