nunit-console icon indicating copy to clipboard operation
nunit-console copied to clipboard

Run CI on PRs and master

Open mikkelbu opened this issue 1 year ago • 1 comments

It seems like we are only running two checks on PRs: WIP and license/cla. So this means that neither AppVeyor nor Azure pipelines are being run as checks on PRs or master (note that AppVeyor run on on both PR and master, but not as a check).

image

mikkelbu avatar Jan 27 '24 18:01 mikkelbu

@mikkelbu I turned off Azure back when I was working on it a year ago. It wasn't working well for me and I was unfamiliar with Azure - and didn't care to get familiar. :-) Working as a contributor, I think I'd just go do something else if I had azure failures right now - AppVeyor is bad enough!

I've always been an advocate of asking committers to not commit until everything is passing but I'm frankly not a fan of software-enforced rules. For one thing, it smells like distrust to me and you shouldn't give people commit authority if you don't trust them to follow sensible rules on their own. Also, most rules need to be overridden from time to time and that often requires a higher level of authority - i.e. asking @OsirisTerje to do it. Given that so few people are working on this, it seems wrong to add obstacles.

As it happens, I just had to push directly to main because of an unresolved. GitVersion bug encountered when trying to run a PR. If that check were in place, I would have been stuck, but I could see that the error had nothing to do with what I was doing and was able to merge and test locally, then push and trigger a build of main, which resolved the bug.

CharliePoole avatar Jun 07 '24 05:06 CharliePoole

A GitHub CI workflow is now run in lieu of the AppVeyor build. It's still not a check for the reasons stated a few months back.

CharliePoole avatar Aug 21 '24 18:08 CharliePoole