docs icon indicating copy to clipboard operation
docs copied to clipboard

ICommandWrapper documentation should say where attribute must be applied

Open oskarb opened this issue 6 years ago • 3 comments

This page: https://github.com/nunit/docs/wiki/ICommandWrapper-Interface

Should state that: Attributes implementing any interface deriving from ICommandWrapper must be placed on a test method. They have no effect when placed on a test fixture.

oskarb avatar Sep 29 '19 10:09 oskarb

Sorry, I wrote that and since I knew I was only talking about methods, I didn't specify. :smile: Obviously, the reader wouldn't know that without being told.

CharliePoole avatar Sep 29 '19 14:09 CharliePoole

Please see the updated doc.

CharliePoole avatar Sep 29 '19 14:09 CharliePoole

Looks good.

Is it the same for IApplyToContext? It does talk about how the contexts are nested and exists at multiple levels, so perhaps that implies that this interface can also be applied at any level (including assembly)? If you are so inclined, perhaps it could be made a little more explicit.

"This interface can be applied to test methods, fixtures, and assemblies". (if that is indeed the case)

oskarb avatar Sep 30 '19 09:09 oskarb