numpy icon indicating copy to clipboard operation
numpy copied to clipboard
verified publisher icon numpy

CI, BLD: Use `cibuildwheel` to build WASM NumPy wheels

Open agriyakhetarpal opened this issue 1 year ago • 3 comments

Description

This PR intends to invoke pypa/cibuildwheel#1456 for building and testing the Pyodide builds for NumPy. cc @rgommers who recommended testing out on a fork of NumPy first, which I did, and I got it to pass.

Update: cibuildwheel version 2.19.1 is out with the required support for Pyodide.

Additional context

  1. Pyodide builds in the cibuildwheel documentation: https://cibuildwheel.pypa.io/en/latest/setup/#pyodide-webassembly-builds-experimental

agriyakhetarpal avatar May 29 '24 16:05 agriyakhetarpal

Do we want an extra CI job for this, or only change the existing one?

rgommers avatar May 30 '24 10:05 rgommers

Do we want an extra CI job for this, or only change the existing one?

Ah, I should have mentioned it in the PR description. I plan to change the existing one to use cibuildwheel after we have a stable release for it – in the meantime, I plan to try this for a few other repositories.

P.S. This could have been incorporated into wheels.yml as well to reduce the number of workflows uploading artifacts or accessing secrets, but considering the instability of the platform, running only on [wheel build] commit messages on PRs and not every time is probably not the best approach.

agriyakhetarpal avatar May 30 '24 11:05 agriyakhetarpal

Sounds good to me, thanks. And yes, I'd prefer to keep it separate from wheels.yml, at least for now.

rgommers avatar May 30 '24 11:05 rgommers

@rgommers is this ready for merging?

mattip avatar Jul 03 '24 06:07 mattip

I just noticed that there were conflicts here. I've merged the latest changes from main and fixed them, so this PR remains ready to merge.

agriyakhetarpal avatar Jul 17 '24 18:07 agriyakhetarpal