numpy.org icon indicating copy to clipboard operation
numpy.org copied to clipboard

remove an extra dash from numpy.org website's title "NumPy - "

Open partev opened this issue 1 year ago • 1 comments

current Numpy.org's website title is "NumPy - "

It is not clear what the purpose of the extra dash is. It feels like something else, like a short description of NumPy was meant to follow after the dash but is somehow missing. I suggest either removing the dash, or adding a short description after the dash.

Screenshot 2024-07-22 01 08 29

partev avatar Jul 22 '24 05:07 partev

I think this comes from the scientific-python hugo theme, from here

 <title>{{ block "title" . }}{{ .Site.Title }}{{ if not (eq .Site.Title .Title) }} - {{ .Title }}{{end}}{{ end }}</title>

Perhaps the main page does not have a .Title attribute. @stefanv thoughts?

mattip avatar Jul 22 '24 05:07 mattip

@mattip can you p[lease check and verify the commit fixed the page title issue 766 and removed the redundant hyphen #658

Musharraffaijaz avatar Jan 13 '25 06:01 Musharraffaijaz

Yes, we'll have to check why "if not (eq .Site.Title .Title)" triggers.

stefanv avatar Jan 13 '25 22:01 stefanv

Problem is that Title is defined for the index page but empty: https://raw.githubusercontent.com/numpy/numpy.org/refs/heads/main/content/en/_index.md

Should be unset, I think.

stefanv avatar Jan 13 '25 22:01 stefanv

Problem is that Title is defined for the index page but empty: https://raw.githubusercontent.com/numpy/numpy.org/refs/heads/main/content/en/_index.md

Should be unset, I think.

The PR, https://github.com/scientific-python/scientific-python-hugo-theme/pull/658 shows the fails builds. Whenever I have tried some changes in the submodules the build fails, can you please suggest me anything why it happens so?

Musharraffaijaz avatar Jan 14 '25 07:01 Musharraffaijaz