Memoize request results wherever possible

[nukeop]

trafficstars

In many cases we could benefit from memoizing stuff like search results from various services to minimize rate limiting and speed up repetitive searches. I plan to do that in the near future but if anyone wants to contribute, even a simple proof of concept in one action would be valuable.

[alizeh12]

Hi, My partner @nfeygin and I would like to work on this if possible

[nukeop]

Okay, if you decide to work on this, let me know which parts are good candidates for memoizing.

[alizeh12]

sure

[devanshim2207]

Hi ! can you please guide me from where should I start on working this ?

[nukeop]

A good place to do this would be here: https://github.com/nukeop/nuclear/blob/master/packages/app/app/actions/search.ts

These thunks fire requests to various services, and the functions that do the requests could memoize results for a given set of search parameters.

[devanshim2207]

which database have you used ?

[devanshim2207]

You 've used this in line 27-> updateSearchHistory: createAction(Search.UPDATE_SEARCH_HISTORY, (searchHistory: string[]) => searchHistory

what's this function for?

[nukeop]

We use Redux for storing search data, I don't want to memoize database access since that would be pretty pointless.

updateSearchHistory stores the last 5 search queries so we can show them as suggestions in the search bar, it's irrelevant for this task.