nuclear icon indicating copy to clipboard operation
nuclear copied to clipboard

Nuclear doesn't download verified streams.

Open Saltane opened this issue 2 years ago • 6 comments

Platform: Linux Nuclear version: 0.6.27 (AUR) Description of the issue: Issue is quite simple. There's a track which if unverified plays undesired stream. After verifying named track to desired stream, download feature of Nuclear downloads track from undesired stream mentioned before. Expected behaviour: After verifying a track, Nuclear will download correct, verified stream.

Saltane avatar Jul 26 '23 20:07 Saltane

Since downloading is implemented in a different place, it does not share the code that normally checks the verification service for matches. It should be added there.

nukeop avatar Jul 26 '23 23:07 nukeop

@nukeop i would like to work on this issue. can you assign me this?

dhananjay-Byte avatar Oct 16 '23 14:10 dhananjay-Byte

I don't assign issues, but you're free to open a pull request.

nukeop avatar Oct 16 '23 15:10 nukeop

@nukeop I've submitted a pull request #1626 that addresses the issue where Nuclear doesn't download verified streams. This enhancement allows users to select and download the desired stream directly, improving the download accuracy.

You can view the pull request here Please review and provide any feedback or suggestions. Thank you!

Krishcode264 avatar Jul 07 '24 11:07 Krishcode264

I decided to close that PR.

nukeop avatar Jul 07 '24 12:07 nukeop

@nukeop yeah i see , we have multiple streams for single track , when user changes the stream for perticular track from the play queue and try to download it from there , it doesnt download that newly selected stream but it always download track.streams[0] , how about if we could add the selectedStreamId to track object when selectNewStream() methode calls so that download service would know what perticular stream has to download for that track , thats what i had implemented in that PR

Krishcode264 avatar Jul 07 '24 14:07 Krishcode264