nuclear icon indicating copy to clipboard operation
nuclear copied to clipboard

Tray icon menu is still in English

Open maboroshin opened this issue 2 years ago • 6 comments

Platform:

nuclear-fd06a3, Windows 10

Description of the issue:

Tray icon menu is still in English.

  • New translation string : "Playing" + "by"
  • Already registered for translation in other parts. : Pause/Next/Previous/Quit

maboroshin avatar Mar 13 '23 03:03 maboroshin

Definitely a bug, might be tricky because it's in the main package.

nukeop avatar Mar 13 '23 10:03 nukeop

Is still bug still an issue? I am completely new to OpenSource and would like to try my best to at least understand and maybe even fix something:)

moritzrose avatar Jul 08 '23 14:07 moritzrose

Yes it is, you can check the i18n package to get an idea of how internationalization works in Nuclear.

nukeop avatar Jul 08 '23 14:07 nukeop

Ok pls correct me if I am wrong, but from what I have understood so far is, that the icons have an english tooltip when I hover over them, and that tooltip needs to be changed according to what language the user is using, correct? In my case, there is actually no tooltip shown at all. I will see what causes that.

So are those suggestions or advice?:

  • New translation string : "Playing" + "by"
  • Already registered for translation in other parts. : Pause/Next/Previous/Quit

moritzrose avatar Jul 08 '23 14:07 moritzrose

@moritzrose What you are talking about is a tooltip.

  • Tooltip : What you see when you hover the mouse cursor over it
  • Menu : It appears when clicked with the mouse cursor on it.

Tooltips and menus are displayed in Windows. I don't know why it's not show, What OS are you using?


Tooltip (Playing):

image

Tooltip (Pause): image


Menu (Playing): image

Menu (Pause): image

Menu (Immediately after start : Nothing has yet played): image

maboroshin avatar Jul 09 '23 08:07 maboroshin

Ah thanks! That helped a ton! Does it make sense for me to work on that problem when I am on macOS? Maybe it's not the best problem to start with, since the problem occurred on windows? But shouldn't it occur on whatever OS then?

moritzrose avatar Jul 09 '23 19:07 moritzrose

This has been fixed in the new release!

nukeop avatar Jul 14 '24 20:07 nukeop