nuclear icon indicating copy to clipboard operation
nuclear copied to clipboard

Windows 10 on ARM platform support

Open ghost opened this issue 3 years ago • 7 comments

Platform: Windows 10 on ARM64 (19044.1415) Nuclear version: / Description of the issue: No available version of nuclear is compatible with Windows 10 on ARM Windows 10 on arm supports the following executables:

  • 32bit x86
  • ARM64

Would it be possible to provide a build for this platform ?

ghost avatar Jan 07 '22 21:01 ghost

We use electron-builder, and I don't see such a configuration option: https://www.electron.build/configuration/win#WindowsConfiguration-target

nukeop avatar Jan 07 '22 23:01 nukeop

I found this https://www.electron.build/cli and this https://github.com/electron-userland/electron-builder/pull/5558. I don't really understand whats going on but i added the --arm64 flag to the windows build script. The build looked good initially but failed later on my side because i was builing on a linux ARM64 host which seems unsupported by electron-builder.

output:

  • writing effective config  file=release/builder-effective-config.yaml
  • rebuilding native dependencies  [email protected] platform=win32 arch=arm64
  • packaging       platform=win32 arch=arm64 electron=12.2.2 appOutDir=release/win-arm64-unpacked
  ⨯ cannot execute  cause=exit status 123
                    errorOut=it looks like wine32 is missing, you should install it.
    as root, please execute "apt-get install wine32"

sysesc avatar Jan 08 '22 21:01 sysesc

Never mind, i found the folder release\win-arm64-unpacked after the build. The release inside works on my machine.

sysesc avatar Jan 08 '22 21:01 sysesc

Nice, then in this case this should only be the matter of adding a flag to the build action so we can generate one more artifact.

nukeop avatar Jan 08 '22 21:01 nukeop

Just kicking the can further down the road.

ArminiusTux avatar Nov 25 '23 21:11 ArminiusTux

This would need to be a little bit more involved: https://github.com/marketplace/actions/run-on-architecture We'd need a separate build step to build on arm64, and then include it in the final list of windows binaries.

nukeop avatar Nov 25 '23 21:11 nukeop