nuclear icon indicating copy to clipboard operation
nuclear copied to clipboard

App should not set as default music or video player after first time open.

Open haidang666 opened this issue 4 years ago • 10 comments

Platform: macOS

haidang666 avatar Oct 17 '21 07:10 haidang666

Not able to reproduce this bug on MacOs

ichaudry avatar Oct 18 '21 01:10 ichaudry

Perhaps it was set back when you use your actual music player app

haidang666 avatar Oct 18 '21 01:10 haidang666

OS: MacOs 11.6 Nuclear Version: 0.6.17

Hi, I could not replicate this issue; my default music/video player settings are unchanged. Are there any more steps to reproduce?

dasanchez981 avatar Nov 13 '21 02:11 dasanchez981

Not sure, I was able to reproduce this on my Mac if there was no default player for .webm and possibly other file formats.

nukeop avatar Nov 13 '21 12:11 nukeop

I can also reproduce this behavior with .webm and .ogg files. Previously, I was not able to reproduce this behavior with .mp3, .3gp, or .mp4 files.

Any ideas on how to go about fixing this issue?

dasanchez981 avatar Nov 16 '21 03:11 dasanchez981

Try this https://www.electronjs.org/docs/latest/api/app#event-open-file-macos

haidang666 avatar Nov 16 '21 03:11 haidang666

Okay thanks. I can try to resolve this issue. How can I assign this to myself?

dasanchez981 avatar Nov 16 '21 03:11 dasanchez981

I assigned to you

haidang666 avatar Nov 16 '21 07:11 haidang666

Hi, I understand I need to change the behavior of the "open-file" event but I'm unable to locate this event in the source code of this repository. Where in the source code of this repository is the "open-file" event currently being handled? Thanks

dasanchez981 avatar Dec 02 '21 17:12 dasanchez981

Hi, I understand I need to change the behavior of the "open-file" event but I'm unable to locate this event in the source code of this repository. Where in the source code of this repository is the "open-file" event currently being handled? Thanks

I don't really know what this means. We should only remove the default file association that sometimes happens on MacOS (i.e. Nuclear is set as the default app to open webm files and some other formats).

nukeop avatar Dec 02 '21 18:12 nukeop