taco-web
taco-web copied to clipboard
Migrate from `ethers-v5` to `viem`
Type of PR:
- Refactor
Required reviews:
- 3
What this does:
- Replaces dependency on
ethers-v5withviem - Introduces signer-provider separation with
WalletClientandPublicClient
Why it's needed:
Explain how this PR fits in the greater context of the NuCypher Network. E.g., if this PR address a
nucypher/productdevissue, let reviewers know!
Notes for reviewers:
- This is just an initial draft
- Rebased over https://github.com/nucypher/taco-web/pull/445 to keep this PR tested (can drop these commits if needed)
- [ ] Remove remainder of
ethersusage - [ ] Remove
typechainusage (based onethers) - [ ] Use
abitype/zodto validatefunctionAbiinstead of relying onethers - Originally drafted in https://github.com/nucypher/taco-web/pull/271
Deploy Preview for taco-nft-demo ready!
| Name | Link |
|---|---|
| Latest commit | 1fb32bdbb230c5ead930a558ef7127e0faba0d11 |
| Latest deploy log | https://app.netlify.com/sites/taco-nft-demo/deploys/658447f8127d35000829180d |
| Deploy Preview | https://deploy-preview-421--taco-nft-demo.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for taco-demo ready!
| Name | Link |
|---|---|
| Latest commit | 1fb32bdbb230c5ead930a558ef7127e0faba0d11 |
| Latest deploy log | https://app.netlify.com/sites/taco-demo/deploys/658447f858e6f10008518b45 |
| Deploy Preview | https://deploy-preview-421--taco-demo.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Attention: 36 lines in your changes are missing coverage. Please review.
Comparison is base (
1a8c590) 88.00% compared to head (1fb32bd) 87.89%.
Additional details and impacted files
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 88.00% 87.89% -0.12%
==========================================
Files 33 33
Lines 2702 2767 +65
Branches 233 239 +6
==========================================
+ Hits 2378 2432 +54
- Misses 293 300 +7
- Partials 31 35 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently fails due to some incompatibility between viem EIP712 signer and verifier on Ursula's side
Error: Threshold of responses not met; TACo decryption failed with errors: {"0x210eeAC07542F815ebB6FD6689637D8cA2689392":"(<class 'nucypher.network.middleware.RestMiddleware.BadRequest'>, BadRequest('Invalid data provided for context variable: Invalid data provided for \":userAddress\"; KeyError - \\'name\\''),
// abbreviated
Closing as stale.