nucliadb
nucliadb copied to clipboard
Initial pagination on semantic and fix on tantivy
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.
This pull request has been linked to Shortcut Story #2153: Provide total results in /search response.
Codecov Report
Base: 66.76% // Head: 67.15% // Increases project coverage by +0.38% :tada:
Coverage data is based on head (
4e74d55) compared to base (88471fc). Patch coverage: 91.48% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 66.76% 67.15% +0.38%
==========================================
Files 194 201 +7
Lines 12421 12635 +214
==========================================
+ Hits 8293 8485 +192
- Misses 4128 4150 +22
| Flag | Coverage Δ | |
|---|---|---|
| ingest | 55.12% <0.00%> (-0.03%) |
:arrow_down: |
| node-sidecar | 76.80% <ø> (ø) |
|
| one | 90.99% <66.66%> (?) |
|
| reader | 76.54% <ø> (ø) |
|
| train | 56.82% <ø> (ø) |
|
| writer | 82.36% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| nucliadb_ingest/nucliadb_ingest/tests/fixtures.py | 41.72% <ø> (ø) |
|
| nucliadb_ingest/nucliadb_ingest/utils.py | 49.27% <0.00%> (-2.24%) |
:arrow_down: |
| nucliadb_one/nucliadb_one/tests/conftest.py | 100.00% <ø> (ø) |
|
| nucliadb_one/nucliadb_one/tests/fixtures.py | 94.91% <66.66%> (ø) |
|
| nucliadb_search/nucliadb_search/search/merge.py | 78.26% <88.57%> (ø) |
|
| nucliadb_search/nucliadb_search/api/models.py | 98.54% <100.00%> (ø) |
|
| nucliadb_search/nucliadb_search/api/v1/search.py | 72.94% <100.00%> (ø) |
|
| nucliadb_search/nucliadb_search/search/query.py | 68.08% <100.00%> (ø) |
|
| nucliadb_search/nucliadb_search/tests/fixtures.py | 97.14% <100.00%> (ø) |
|
| ..._search/nucliadb_search/tests/test_basic_search.py | 100.00% <100.00%> (ø) |
|
| ... and 13 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.