css-in-js-loader icon indicating copy to clipboard operation
css-in-js-loader copied to clipboard

Published 20 hours ago • verified publisher icon ntharim

Allow usage with webpack 2.2 and with postcss-js up to 1.0

Open mistadikay opened this issue 8 years ago • 4 comments
trafficstars

Hey!

I'm using your loader with webpack 2 and postcss-js 0.3.0 and didn't notice any issues. So I'm suggesting to allow these versions as peer dependencies.

mistadikay avatar May 05 '17 14:05 mistadikay

Thanks @mistadikay! I've been a bit busy but will look into testing and merging this soon. Have you noticed any issues so far since you opened this PR?

ntharim avatar May 12 '17 02:05 ntharim

No issues so far! But feel free to test on your own, just in case.

mistadikay avatar May 12 '17 08:05 mistadikay

btw, I upgraded postcss-js to 1.0 recently — and still no issues. Perhaps we can allow this version as well

mistadikay avatar May 12 '17 08:05 mistadikay

We have been running this plugin with the latest version of all the peer dependencies, is there any objection to updating them (even beyond this PR)? Mainly because they are resulting in warnings in our output that i'd like to get rid of.

michaeltaranto avatar Jan 16 '19 00:01 michaeltaranto