nestjs-sentry
nestjs-sentry copied to clipboard
Making logging optional
- get rid of ConsoleLogger inheritance:
- use
SentryService implements LoggerServiceinstead ofSentryService extends ConsoleLogger;
- use
- add an ability to provide custom logger;
- add an ability to disable logging entirely;
- default logger is
ConsoleLoggerfor backward compatibility;
This currently has conflicts with the master branch...
@ntegral merged!
@holm @doctorrokter any chance of merging this? Would enable custom logger usage in combination with nestjs-sentry.
@doctorrokter I wanted to ping this one more time to see if it's feasible to get the merge conflicts resolved and merge this PR.
I understand the OP was pretty responsive to feedback and yet the PR still didn't get merged, which can be frustrating. I'm hoping the repo maintainers can jump on this if the merge conflicts get resolved again. If the merge conflicts don't get addressed soon, I might re-fork these changes and resubmit a matching PR, because this change would really help my team deal with messy logs.