nestjs-sentry icon indicating copy to clipboard operation
nestjs-sentry copied to clipboard

Making logging optional

Open doctorrokter opened this issue 4 years ago • 4 comments

  • get rid of ConsoleLogger inheritance:
    • use SentryService implements LoggerService instead of SentryService extends ConsoleLogger;
  • add an ability to provide custom logger;
  • add an ability to disable logging entirely;
  • default logger is ConsoleLogger for backward compatibility;

doctorrokter avatar Aug 23 '21 08:08 doctorrokter

This currently has conflicts with the master branch...

ntegral avatar Oct 25 '21 11:10 ntegral

@ntegral merged!

doctorrokter avatar Oct 31 '21 04:10 doctorrokter

@holm @doctorrokter any chance of merging this? Would enable custom logger usage in combination with nestjs-sentry.

nkovacic avatar Mar 21 '22 05:03 nkovacic

@doctorrokter I wanted to ping this one more time to see if it's feasible to get the merge conflicts resolved and merge this PR.

I understand the OP was pretty responsive to feedback and yet the PR still didn't get merged, which can be frustrating. I'm hoping the repo maintainers can jump on this if the merge conflicts get resolved again. If the merge conflicts don't get addressed soon, I might re-fork these changes and resubmit a matching PR, because this change would really help my team deal with messy logs.

CalMlynarczyk avatar Mar 15 '23 22:03 CalMlynarczyk