NSubstitute icon indicating copy to clipboard operation
NSubstitute copied to clipboard

404 from Documentation Links

Open aukevin opened this issue 6 months ago • 7 comments

A lot of the documentation pages have links that give a 404. For example, the return-from-function help doc link https://nsubstitute.github.io/help/return-from-function shows: Image

I think there may have been some missing files during the migration: https://github.com/nsubstitute/NSubstitute/commit/4437c2b97d296ce4e584af89064194b705a345a5

aukevin avatar Jun 03 '25 19:06 aukevin

Where is that url located?

This link works for me

From: https://nsubstitute.github.io/docs/2010-01-01-getting-started.html

Image

It links to https://nsubstitute.github.io/docs/2010-02-03-return-from-function.html

304NotModified avatar Jun 03 '25 20:06 304NotModified

Ow I see almost every link on https://nsubstitute.github.io/docs/2010-01-01-getting-started.html

Gives a 404 :(

E.g. these 3

Image

304NotModified avatar Jun 03 '25 20:06 304NotModified

@Romfos , @dtchepak any idea?

304NotModified avatar Jun 03 '25 20:06 304NotModified

Yea, we have dates at article names and URLs My proposition is to remove it

We have documentation in /docs in this repo

How to check documentation locally:

  1. open terminal in /docs folder
  2. install docfx dotnet tool dotnet tool install -g docfx
  3. run docfx build --serve --open-browser

maybe you can create a PR with fix?

Romfos avatar Jun 04 '25 05:06 Romfos

I think it's a good idea to remove the dates from the urls :)

PR would be great

304NotModified avatar Jun 04 '25 11:06 304NotModified

Thanks for raising this @aukevin !

@304NotModified I had a go at fixing this: https://github.com/nsubstitute/NSubstitute/pull/886

dtchepak avatar Jun 09 '25 07:06 dtchepak

I'll look forward to to the fix!

aukevin avatar Jun 10 '25 00:06 aukevin

This should be fixed now @aukevin . Thanks for the report! Please let me know if you find more issues with this 🙇

dtchepak avatar Jul 13 '25 10:07 dtchepak