DoomLauncher icon indicating copy to clipboard operation
DoomLauncher copied to clipboard

[bug] Ratings aren't used and the data is wrong

Open kenbot opened this issue 1 year ago • 3 comments
trafficstars

The Rating field in GameFile is typed as double?, but the database field in SQLite is INTEGER. In my tests, the "double" is getting saved to the "INTEGER" column, possibly as a string, thanks to SQLite's loosey-goosey column types, but comes back cast as an Int, thanks to the software layer.

As far as I can tell none of this is used by the real code: when I download a WAD from idgames that has a listed rating, the rating column is still NULL.

Not a biggie, but I'm planning to just ignore the Rating field in the tests.

kenbot avatar Jul 19 '24 09:07 kenbot