Nico Schlömer

Results 521 comments of Nico Schlömer

> I actually thought that gmsh only generates cells for objects decleared physical, but that may be a wrong or outdated assumption on my part. @keileg I thought so too,...

Well, if there is no data for a particular cell type, we have to do _something_. Setting it to `None` makes pretty clear what's going on I think.

This needs tests. Take a look at the other format tests -- they essentially all so the same.

Yes, reading is required.

This looks good. How about adding a test file? Doesn't need to be fancy. The most important thing is the write-read test; take a look at the other tests, they...

@nicola-sorace Are you still interested in finishing this?

I'd check out the other tests, some are only 5 lines, e.g., dolfin or tetgen. You don't need more than that.

The error is ``` ModuleNotFoundError: No module named 'helpers' ``` You'll also need to run `make format` to make the linter happy.

> ok, I've added simple tests but they fail because the reader doesn't always output the correct node ordering. Right, that's the issue now. Would be cool to get this...

> 'rotation' of elements is lost in the way OpenFOAM stores mesh data. Well there must be _some_ ordering, right? The quad [0,1,2,3] is different from [0,1,3,2]. How does openfoam...