nx icon indicating copy to clipboard operation
nx copied to clipboard

missaligned padding for terminal output with failed tasks

Open Den-dp opened this issue 1 year ago • 1 comments

Current Behavior

When running multiple targets like nx run-many -t lint, the first task (- nx run bar:lint) doesn't look properly padded:

 NX   Ran target lint for 3 projects (3s)

   √  0/3 succeeded [0 read from cache]

   ×  3/3 targets failed, including the following:

      - nx run bar:lint
       - nx run baz:lint
       - nx run foo:lint

Expected Behavior

here is how it was aligned in nx@17

 >  NX   Ran target lint for 3 projects (3s)                                                                                                                                                                                      
                                                                                                                                                                                                                                  
    √    0/3 succeeded [0 read from cache]                                                                                                                                                                                        
                                                                                                                                                                                                                                  
    ×    3/3 targets failed, including the following:                                                                                                                                                                             
         - nx run bar:lint
         - nx run foo:lint
         - nx run baz:lint

GitHub Repo

No response

Steps to Reproduce

npx create-nx-workspace@18 nx18
npx nx generate library foo
npx nx generate library bar
npx nx generate library baz
nx run-many -t lint

Nx Report

> nx report

 NX   Report complete - copy this into the issue template

Node   : 20.12.2
OS     : win32-x64
npm    : 10.7.0

nx (global)        : 18.3.4
nx                 : 18.3.4
@nx/js             : 18.3.4
@nx/jest           : 18.3.4
@nx/linter         : 18.3.4
@nx/eslint         : 18.3.4
@nx/workspace      : 18.3.4
@nx/devkit         : 18.3.4
@nx/eslint-plugin  : 18.3.4
@nrwl/tao          : 18.3.4
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx/jest/plugin

Failure Logs

No response

Package Manager Version

No response

Operating System

  • [ ] macOS
  • [ ] Linux
  • [X] Windows
  • [ ] Other (Please specify)

Additional Information

Might be related to #22189 #21809

Den-dp avatar May 01 '24 12:05 Den-dp

Looks like the space in .join('\n ') became redundant over time and might be removed in order to fix the issue:

https://github.com/nrwl/nx/blob/22ef42a475f14fdc8734a9d21f73d42f05f1f28e/packages/nx/src/tasks-runner/life-cycles/dynamic-run-many-terminal-output-life-cycle.ts#L405-L412

Den-dp avatar May 01 '24 13:05 Den-dp

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

github-actions[bot] avatar Jun 01 '24 00:06 github-actions[bot]