Nick Mancuso

Results 391 comments of Nick Mancuso

Yup, this is issue is just a convenient place to easily drop ideas. We will analyse what we come up with here and generate comprehensive issues when the time is...

Another issue that could be considered for this: https://github.com/checkstyle/checkstyle/issues/14825

Parenpad for record pattern def: https://checkstyle.sourceforge.io/checks/whitespace/parenpad.html#ParenPad

@mahfouz72 please confirm that we have covered all that is mentioned here in our tracker issues, then I will close this.

> @romani - can you guide me how to fix this problem? > > https://app.circleci.com/pipelines/github/checkstyle/checkstyle/22461/workflows/591057a6-c1e6-415f-86a3-8ccea621daad/jobs/456518?invite=true#step-103-30024_119 These are checkstyle violations on the code in this PR, please fix them and examine...

@kalpadiptyaroy like romani mentioned at https://github.com/checkstyle/checkstyle/pull/14149#issuecomment-1871454992, if `mvn clean verify` is not passing on your local, result in CI will be the same.

@kalpadiptyaroy looks like a bad config, please use template from checkstyle-tester, remove example checks, and add your check

> @romani @nrmancuso. Hi, have solved all the CI failures. Only one CI failure is left, and it is arising due to the changes suggested in [#14149 (comment)](https://github.com/checkstyle/checkstyle/pull/14149#discussion_r1438680696). > >...

@smitsekhadiaa do you plan to continue this PR?

@MANISH-K-07 let's get this across the finish line