vscode-hide-gitignored icon indicating copy to clipboard operation
vscode-hide-gitignored copied to clipboard

Published 20 hours ago • verified publisher icon npx

Ignore patterns from global gitignore

Open matusf opened this issue 5 years ago • 8 comments
trafficstars

Hi! First of all, thanks for this awesome extension! I've added a functionality to ignore patterns from global git ignore. I'm sorry if this is not the most idiomatic typescript, I was coding in typescript for the first time :smiley: However, I'm happy to follow your review recommendations if you have any.

closes #1

matusf avatar Mar 18 '20 23:03 matusf

Hello @matusf!

Thank you for your work! In order to incorportate your change more easily I updated the project a little bit and added code formatting.

I would appreciate it if you could rebase your changes onto my latest upstream changes.

As for the code, I will add some comments!

npx avatar Mar 21 '20 14:03 npx

@npx rebased!

matusf avatar Apr 02 '20 18:04 matusf

@matusf can you see the comments I made a while ago?

npx avatar Apr 02 '20 23:04 npx

No, I don't see any of them.

matusf avatar Apr 02 '20 23:04 matusf

ping @npx

matusf avatar Jan 06 '21 08:01 matusf

Yes, I see it now, thanks. I'll make the changes shortly.

matusf avatar Jan 12 '21 15:01 matusf

Hi @npx, I've made the changes. Could you please check if it's all ok?

matusf avatar Feb 11 '21 19:02 matusf

@npx good enhancement. I would vote to include this.

LuisPeregrina avatar Feb 24 '22 02:02 LuisPeregrina